APIv4 - Don't show campaign_id in getFields if campaign component disabled #20219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
I think the failing test must need campaign enabled |
colemanw
force-pushed
the
campaignComponent
branch
from
52bc394 to
88c31c0
Compare
|
Looks good to me merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a
componentflag to fields so they can be hidden if their component is disabled.Before
Irrelevant
campaign_idfields appear in the list of fields for SearchKit & Afform.After
Now they don't.
Technical Details
APIv4 only. Didn't want to mess with legacy stuff.