[REF] Post move cleanup - switch from $form to $this

[eileenmcnaughton]

Overview

[REF] Post move cleanup - switch from $form to $this

Before

$form = $this & $form used

After

$this used

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Test fails relate

CRM_Contribute_Form_Task_PDFLetterCommonTest::testBuildContributionArray
Non-static method CRM_Contribute_Form_Task_PDFLetter::buildContributionArray() should not be called statically

/home/jenkins/bknix-dfl/build/core-20160-18ywr/web/sites/all/modules/civicrm/tests/phpunit/CRM/Contribute/Form/Task/PDFLetterCommonTest.php:155
/home/jenkins/bknix-dfl/build/core-20160-18ywr/web/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:226
/home/jenkins/bknix-dfl/extern/phpunit7/phpunit7.phar:615

CRM_Contribute_Form_Task_PDFLetterCommonTest::testPostProcessGroupByContact
Undefined index: contribution

/home/jenkins/bknix-dfl/build/core-20160-18ywr/web/sites/all/modules/civicrm/CRM/Contribute/BAO/Contribution.php:5301
/home/jenkins/bknix-dfl/build/core-20160-18ywr/web/sites/all/modules/civicrm/CRM/Contribute/Form/Task/PDFLetter.php:322
/home/jenkins/bknix-dfl/build/core-20160-18ywr/web/sites/all/modules/civicrm/CRM/Contribute/Form/Task/PDFLetter.php:209
/home/jenkins/bknix-dfl/build/core-20160-18ywr/web/sites/all/modules/civicrm/tests/phpunit/CRM/Contribute/Form/Task/PDFLetterCommonTest.php:288
/home/jenkins/bknix-dfl/build/core-20160-18ywr/web/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:226
/home/jenkins/bknix-dfl/extern/phpunit7/phpunit7.phar:615