Afform - Fix loading entities from url args

[colemanw]

Overview

Fixes https://lab.civicrm.org/dev/core/-/issues/2567

Loading existing entities via url args was not working.

Before

Url arguments ignored.

After

Now entities can be loaded with a url like civicrm/my/afform#!?Individual1=123

Comments

This broke when we stopped using ngRoute.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

#!?

[seamuslee001]

@colemanw I tried this out locally but ran into a problem where by when it was trying to do the prefill with args of {Individual1: "198"} got error Cannot process APIv4 request for Individual1 (Contact.get): Action is not approved

[colemanw]

@seamuslee001 what the #!? does that error mean?

[colemanw]

You know what @eileenmcnaughton - your comment got me thinking and I decided the best thing is to remove that ! character globally, not just on pages that use crmApp.
#20152

[seamuslee001]

@colemanw that error seems to come from here

civicrm-core/ext/afform/core/Civi/Afform/FormDataModel.php

Line 84 in 5db0bc3

throw new UnauthorizedException("Cannot process APIv4 request for $entityName ($entity.$action): Action is not approved");

maybe the recent RBAC/FBAC work that Tim did broke prefill somehow ?

[eileenmcnaughton]

@seamuslee001 @colemanw - just trying to figure out the status here - is it blocked on #20152 ? I guess more directly it's blocked on the issue @seamuslee001 hit

[colemanw]

I don't think #20152 is a blocker per-se but I think it ought to be merged. @totten can you please take a look?
I'll try to reproduce the issue Seamus hit.

[eileenmcnaughton]

@seamuslee001 do you still think there is an error with this PR? I think it would be good to hit the rc before it forks as this is really a regression

[eileenmcnaughton]

I tested this & was able to get this to work

https://dmaster.localhost:32353/civicrm/monolog#!?Monolog1=1

There are still some issues in getting that form to fully work but this PR fixes this part & it is actually a regression so let's get it merged before forking

I didn't experience the bug @seamuslee001 did - but we can merge a fix to that to the rc if that is a regression from this or a pre-existing regression