[NFC/Unit Test] - Help avoid problems when using assertApproxEquals with integers instead of fractions

[demeritcowboy]

Overview

Pick up my guitar and play
Just like yesterday
Then I'll get on my knees and pray
We don't get fooled again

This makes your test fail if you pass integers into assertApproxEquals with a threshold of 1. It's come up twice that I know of. It gives you a helpful message to use a bigger number, such as 2, or 5.

Before

Kinda

After

Sorta

Technical Details

Integers-first is how humans think, not fractions as do Alpha-Centaurans, or complex numbers as do humpback whales (source: Star Trek IV). But the approxEquals function is a fractions-first thinking function, where a threshold of 1 when applied to integers means they need to be identical.

Fool me once shame on you. Fool me ... can't get fooled again.

Comments

Is test

@seamuslee001

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

• General standards
  • (r-explain) Pass: https://www.youtube.com/watch?v=UDfAdHBtK_Q
  • (r-user) Undecided:
  • (r-doc) Undecided
  • (r-run) Undecided:
• Developer standards
  • (r-tech) Undecided:
  • (r-code) Undecided
  • (r-maint) Undecided
  • (r-test) Undecided