Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ref] Simplify getMembershipParameters #20014

Merged
merged 2 commits into from
Apr 15, 2021
Merged

[Ref] Simplify getMembershipParameters #20014

merged 2 commits into from
Apr 15, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[Ref] Simplify getMembershipParameters

Before

$formValues need to be passed in to support weird wrangling

After

More readable, submitted values retrieved as needed

Technical Details

Comments

@civibot
Copy link

civibot bot commented Apr 9, 2021

(Standard links)

@civibot civibot bot added the master label Apr 9, 2021
@eileenmcnaughton
Copy link
Contributor Author

@monishdeb should be simple-ish

@colemanw
Copy link
Member

This is well-tested.

@colemanw colemanw merged commit c98053c into civicrm:master Apr 15, 2021
@eileenmcnaughton eileenmcnaughton deleted the mem_params branch April 15, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw