[WIP] dev/core#2473 - Don't crash when assignee left blank when creating followup on email activity

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/2473

Before

1. Create an email activity.
2. Fill out the followup section near the bottom but leave the assignee there blank.
3. Crash.

After

No crash.

Technical Details

The function ends up passing in array(0 => ""), which technically is not an empty array. Some changes in 5.31 end up converting the "" to a 0 instead of ignoring it which then causes a violation constraint for the assignee id.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

This looks good to me merging

[demeritcowboy]

Thanks! I was going to write a test and check into why the regular activity form doesn't seem to need this, but I suppose I can still do that.