Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular - Remove deprecated js file #19704

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Mar 1, 2021

Overview

Removes an unused js file that has been deprecated for years.

@civibot
Copy link

civibot bot commented Mar 1, 2021

(Standard links)

@civibot civibot bot added the master label Mar 1, 2021
@totten
Copy link
Member

totten commented Mar 1, 2021

Confirmed by grepping universe for crmDepend and crm.angular.js - it really doesn't appear to be used. Merge on pass.

Tangentially, there is another reference in karma.conf.js. Not important or blocking - just related.

@colemanw colemanw merged commit 16972ca into civicrm:master Mar 1, 2021
@colemanw colemanw deleted the removeDeprecatedAngularJs branch March 1, 2021 21:01
@colemanw
Copy link
Member Author

colemanw commented Mar 1, 2021

@totten I removed one reference from Karma already in this PR, was there another?

@totten
Copy link
Member

totten commented Mar 1, 2021

I removed one reference from Karma already in this PR, was there another?

Nope. Think that's my bad -- when I grepped universe, it hit the line in civicrm-core@master, and I probably forgot to double-check the PR.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants