dev/core#1207 - My Cases dashlet shouldn't crash for users with only my cases access

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/1207

1. Turn on civicase.
2. Make a user that has access my cases and activities permission but not access all cases and activities permission.
3. Log in as that user.
4. Create a case (the problem doesn't appear if there aren't any cases).
5. Add the My Cases dashlet to the dashboard.
6. Cursor spins.

Before

• Spinning logo.
• DB error: no such field
  • Unknown column 't_act.activity_type_id' in 'field list'

After

Dashlet loads

Technical Details

The ajax call is passing an invalid value for the type url parameter, but it only happens when the user only has Access My Cases permission and only for the My Cases dashlet. When type isn't one of the valid values then there's a missing table in the query that gets generated. See ticket for more details.

The material code change here is that the middle expression in the if-else-then is replaced with an expression that converts "my-cases" to "any". The rest is I just moved it into a function.

Note that list is also used as part of the css class names and ultimately how the datatable is targeted, so I didn't want to change anything around that.

Comments

I can't think of how to write a test for this since it's in the javascript and the problem is an invalid value is being put in the url.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I had some trouble replicating this as I had to expand the dashlet to get the error (possibly it was browser caching results when I was logged in as a different user, not sure) - however, I was in the end able to confirm the issue and that this fixed it

[demeritcowboy]

Thanks. Yes dashlets seem very cachey sometimes.