Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joomla::synchronizeUsers - Fix notice due to old style reference #19677

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

totten
Copy link
Member

@totten totten commented Feb 26, 2021

Overview

This fixes a PHP notice when synchronizing all users/contacts.

Before

PHP Notice:  Only variables should be assigned by reference in ...CRM/Utils/System/Joomla.php:855

After

No notice.

Comments

I think I got this notice originally while running authx's AllFlowsTest. You can probably replicate with something like

cv ev '\CRM_Utils_System::synchronizeUsers();'

This fixes a PHP notice when synchronizing all users/contacts:

PHP Notice:  Only variables should be assigned by reference in ...CRM/Utils/System/Joomla.php:855
@civibot
Copy link

civibot bot commented Feb 26, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

yeah - that looks like it was wrong

@eileenmcnaughton eileenmcnaughton merged commit 185657d into civicrm:master Feb 26, 2021
@totten totten deleted the master-joomla-syncuser branch March 2, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants