dev/core#1400 Users with 'view own cases' permission can't open resolved cases

[kainuk]

Overview

The discussion about this PR is found in issue https://lab.civicrm.org/dev/core/-/issues/1400.
Steps to reproduce in https://lab.civicrm.org/dev/core/-/issues/2409 .
The discussion is still open but for some organisations this creates a real problem. They can use this PR.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Thanks @kainuk have added #19674 and then followup #19675 to address the change this causes for dashlets.

jenkins retest this please.

[eileenmcnaughton]

So my take on what is going on is that you think this should be merged @demeritcowboy and then you would like @kainuk to review your 2 follow ups - if that is the case can you confirm & @kainuk can you remove WIP?

[demeritcowboy]

While I'd like to find out what changed to cause this problem, removing 'any' appears to be a way to fix the problem that only seems to affect the dashlets, and in any case (double pun) there doesn't seem to be a reason for 'any' to be in this line (i.e. semantically why would asking for type='any' add a restriction).

I do have one hesitation in that the My Cases dashlet has other problems, but that's both before and after this, it just might be a clue as to the real problem.

[demeritcowboy]

In my testing this goes back much farther than 5.12 as indicated in the ticket, and even predates the dashlet(?!) So yes I think can remove WIP here and it's mergeable and dashlet problems are something completely different.

[eileenmcnaughton]

OK - done

[demeritcowboy]

Thanks