Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i18n issue with changeLog in data templates #19651

Conversation

lunar-debian
Copy link
Contributor

Overview

There was a small mistake with the translation delimiters of Change Log in data templates.

Before

Unable to properly translate the Change Log entry. It was Changer Log in French which is wrong.

After

Proper translation is possible.

There was a small mistake with the translation delimiters of `Change Log` in data templates.
@civicrm-builder
Copy link

Can one of the admins verify this patch?

@civibot
Copy link

civibot bot commented Feb 22, 2021

(Standard links)

@civibot civibot bot added the master label Feb 22, 2021
@demeritcowboy
Copy link
Contributor

Good catch 👍 . For anyone else reviewing you can't see this on the public demo or PR test sites because you would need to do the initial install in another language, not just switch the language after.

Where this comes up is on e.g. admin - customize - display prefs about half-way down where it says "contact search".

@eileenmcnaughton
Copy link
Contributor

Looks right - I guess doing a data update would be tricky on existing sites though- I'm happy just to fix in new installs (as this does)

@eileenmcnaughton eileenmcnaughton merged commit 9ce5a75 into civicrm:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants