Remove single use of extraParams in CRM_Utils_Token::getTokenDetails()

[mattwire]

Overview

I wanted to switch CRM_Utils_Token::getTokenDetails() to API4 but the existence of $extraParams makes this difficult. Turns out it's only used in one place and can easily be removed.

Before

$extraParams may be passed to tokens query.

After

$extraParams not used.

Technical Details

Calling getTokenDetails with [0] makes no sense because nothing is returned.

Comments

@eileenmcnaughton I started looking at some of the differences in contact token parsing and thought that both old/new functions would be simplified a lot if we switched them to API4.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@mattwire I agree that the extraparams is only passed from one place and that it is meaningless as it simply further-filters the $params used for contact retrieval - which should not be necesssary as ids is passed in. This is a helpful simplification

I had been looking at how to move the other function to apiv4 - although I wanted to see if people agree about removing some tokens first (hash, the fields that return the template for the greetings)