Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect use of ts when setting custom data form title #19625

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

colemanw
Copy link
Member

Overview

Fix incorrect string translation. English variable names should not be inserted into the translated string as they will be untranslatable.

Before

Untranslatable strings "Add" "Edit" "Copy"

After

Fixed.

Comments

Also removed redundant CRM_Utils_Request::retrieve('mode' because the same call is made 5 lines above.

@civibot
Copy link

civibot bot commented Feb 18, 2021

(Standard links)

@civibot civibot bot added the master label Feb 18, 2021
@demeritcowboy
Copy link
Contributor

This works and translates properly and looks good.

Aside: There's also a "View %1 Record" which is elsewhere but which is already ok, just now is slightly inconsistent since it still has the word "record".

@eileenmcnaughton
Copy link
Contributor

Merging based on @demeritcowboy's review

@eileenmcnaughton eileenmcnaughton merged commit 57ef507 into civicrm:master Feb 19, 2021
@eileenmcnaughton eileenmcnaughton deleted the fixTs branch February 19, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants