core#2309: Validate weight and weight threshold

[monishdeb]

Overview

CiviCRM Find and Merge Duplicate Contacts, does not validate the weight and weight threshold, possible to set a weight threshold which can never be achieved. Resulting in a defunct duplicate matching rule and lots of duplicate contacts.

Before

Doesn't Validate the field weight(s) with weight threshold:

After

Validate the field weight(s) with weight threshold

Comments

ping @eileenmcnaughton @jusfreeman

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

The patch works - the wording on the error message is not quite right - how about 'The field weights must add up to, or exceed, the threshold weight' -

[petednz]

Good to see this getting a fix

[agileware-justin]

Thanks for the PR @monishdeb

Two suggestions:

1. Change the logic for weight total and weight threshold to be >= (greater than or equal too), as it's currently equal - which is not required for a valid de-dupe rule, as shown in the screenshot below.
2. Change wording to be "Total weight must be greater than or equal to the Weight Threshold" - use the same wording of "Weight Threshold" to reinforce which field is being referred too.

[monishdeb]

@agileware-justin @eileenmcnaughton thanks for your feedback, updated the PR

Isn't the logic should be

IF Total Weight < Threshold weight 
   then 'Total weight must be greater than or equal to the Weight Threshold'

as per the error message?

[eileenmcnaughton]

@jusfreeman this looks right to me now - please confirm & I can merge-on-pass it

[agileware-justin]

Thanks @monishdeb - yes, looks good to me now.

[eileenmcnaughton]

@monishdeb it doesn't look like the final merged version of this was actually right - see #19952