[REF] replace deprecated calls with buildOptions

[MegaphoneJon]

Overview

I'm replacing two calls to deprecated functions with their modern equivalent.

Before

CRM_Contribute_PseudoConstant::paymentInstrument()

After

CRM_Contribute_BAO_Contribution::buildOptions()

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

This looks good. Name/label and is_active seem to work out the same.

To save microseconds a future PR could maybe improve how it gets checkPaymentID in the first place, instead of getting all the options and then doing array_search.