serialize as boolean setting value for checkbox in CRM_Admin_Form_Gen… #19576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Serialize setting value as boolean for checkbox in CRM_Admin_Form_Generic.
Issue: https://lab.civicrm.org/dev/core/-/issues/2371
Before
When a setting is defined as "Boolean / Checkbox" in its metadata, the Form
CRM_Admin_Form_Genericsaves it as integer value (serialized incivicrm_setting.valuetable)After
The setting is serialized as bool
Technical Details
cast checkbox value as bool
Comments
Something similar happens with setting "Integer / Textbox" where the value is serialized as string in MySQL. But I'd tackle that issue in a different PR