Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Rename variable to clarify it's usage #19556

Merged
merged 1 commit into from
Feb 7, 2021

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Feb 7, 2021

Overview

Found while looking into building pricesets for contributionpages (see #19475).

This variable is misleading because the code works correctly but does the opposite of what the variable makes you think!

Before

Misleading variable name.

After

Clear, consistent variable name.

Technical Details

Comments

@civibot
Copy link

civibot bot commented Feb 7, 2021

(Standard links)

@civibot civibot bot added the master label Feb 7, 2021
@demeritcowboy
Copy link
Contributor

Doing a code read this looks good.

@seamuslee001 seamuslee001 merged commit d4bc3b1 into civicrm:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants