[REF] Use form property rather than formValues to pass generated invoice ID on membership forms #19549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
…ice ID formValues is 'sort of' the array for 'submittedValues' but it has stuff added to it & passed around. This is part of an attempt to make it clearer where various values come from to faciliate cleaning up the code and removing some of the very many arrays in use.
eileenmcnaughton
force-pushed
the
member
branch
from
99e9ce3 to
66de72b
Compare
|
@yashodha are you OK merging this too (I just rebased it after that other one you merged for me) |
|
@eileenmcnaughton looks good, merging this. |
|
thanks @yashodha that unblocks me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Use form property rather than formValues to pass generated invoice ID on membership forms
Before
invoice ID added to formvalues array and passed around
After
Invoice id retrieved with a consistent getInvoiceID method, making the consistency of the passed array less important
Technical Details
formValues is 'sort of' the array for 'submittedValues' but it has stuff added to it
& passed around. This is part of an attempt to make it clearer where
various values come from to faciliate cleaning up the code and
removing some of the very many arrays in use.
Comments