[REF] Fully remove contribution object from repeattransaction function

[eileenmcnaughton]

Overview

[REF] Fully remove contribution object from repeattransaction function

Before

Object passed in but not used in any meaningful way

After

Poof

Technical Details

We can now see it is no longer used & remove it

This slightly grew in scope - with the overrides handling being tidied up & moved to getTemplateContribution because I hit a few test errors & the easiest way seemed to be to finish the cleanup

Comments

test cover on some of the tricksier things

testRepeatTransactionPassedInFinancialType
testRepeatTransactionPassedInCampaign
testRepeatTransactionUpdatedCampaign
testRepeatTransactionAlteredAmount

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

Looks like test fails relate:

CRM_Contribute_Form_Contribution_ConfirmTest.testPayNowPayment
api_v3_ContributionTest.testRepeatTransactionWithCustomData

[eileenmcnaughton]

Yep - I can see what the error was that they caught - the 'id' field was leaking