APIv4 - Increase alias max length to 256 #19537
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a bug in Search Kit where fields derived from long complex joins would disappear because their alias was longer than the default length of 63 output by
CRM_Utils_String::munge()
.Before
Some fields appear missing in Search Kit results table.
After
Fixed.
Comments
I'm not sure Search Kit would ever generate an alias longer than 256 characters but we should maybe do some abbreviating in the alias construction to avoid ever running into that problem.