Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv4 - Increase alias max length to 256 #19537

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Feb 5, 2021

Overview

Fixes a bug in Search Kit where fields derived from long complex joins would disappear because their alias was longer than the default length of 63 output by CRM_Utils_String::munge().

Before

Some fields appear missing in Search Kit results table.

After

Fixed.

Comments

I'm not sure Search Kit would ever generate an alias longer than 256 characters but we should maybe do some abbreviating in the alias construction to avoid ever running into that problem.

@civibot
Copy link

civibot bot commented Feb 5, 2021

(Standard links)

@civibot civibot bot added the master label Feb 5, 2021
@eileenmcnaughton eileenmcnaughton merged commit 5f46da1 into civicrm:master Feb 5, 2021
@colemanw colemanw deleted the aliasLength branch February 5, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants