[REF] Complete order Unset contribution once we have finished with it.

[eileenmcnaughton]

Overview

[REF] Complete order Unset contribution once we have finished with it.

Before

A whole lotta stuff is happening with the contribution object - but we can't see to what end

After

Checked whether it IS still used after repeatransaction & altered the one place that does use it, unset it to make that clear & avoid that checking work needing to be re-done

Technical Details

This patch does very little but it takes a bit of searching to check the handful of places
that call completeOrder and check that none of them use the contribution
object after this function call. With this merged it will be possible to
cleanup the references to the contribution in the repeattransaction
code safe in the knowledge that the object is not needed after that
function (or within it from my reading). It seems likely we can switch to
passing in contributionID rather than the whole object.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

Agreed