Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2248 Ensure variables are assigned to tpl for urls #19183

Merged
merged 1 commit into from
Dec 12, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Dec 11, 2020

Overview

Fixes a regression where the edit link from the view participant page doesn't work when reached from search results

Before

When viewing a "Participant" record, the "Edit" button is broken.

  1. Navigate to "Events" => "Find Participants"
  2. Enter some search criteria (or blank criteria). Run the search.
  3. On one of the "Participant" records, click "View"
  4. The "View" screen has a button bar which includes an "Edit" button. Click it.

After

Fixed

Technical Details

This is the same place the urlPath is assigned to is logical. Adding them conditionally is mostly precautionary

Comments

@civibot
Copy link

civibot bot commented Dec 11, 2020

(Standard links)

@totten
Copy link
Member

totten commented Dec 11, 2020

r-run on 5.33. Result looks good. Patch/code looks straightforward. Merge on pass.

@seamuslee001 seamuslee001 merged commit 3efb1e7 into civicrm:5.33 Dec 12, 2020
@seamuslee001 seamuslee001 deleted the 533e branch December 12, 2020 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants