dev/core#2188 - Upgrader - Cleanup any invalid combinations of is_search_range

[totten]

Overview

Certain custom-field configurations are not sensible - notably, #11 below:

+----+-----------+-----------+---------------+-----------------+--------------+
| id | data_type | html_type | is_searchable | is_search_range | comment      |
+----+-----------+-----------+---------------+-----------------+--------------+
| 00 | Int       | Radio     |             0 |               0 | Sensible     |
| 10 | Int       | Radio     |             1 |               0 | Sensible     |
| 11 | Int       | Radio     |             1 |               1 | Not sensible |
+----+-----------+-----------+---------------+-----------------+--------------+

In 5.30, the search screen was forgiving about these - but in 5.31+, it became unforgiving.

The previous fix (#18970) prevents creation of new fields in configuration #11. However, existing fields would still be problematic.

Before

Upgraders retain problematic configurations, which become symptomatic in newer versions.

After

Upgraders get valid configurations.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).