Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tabs cleanup toward fixing dev/core#2215 #19065

Merged
merged 1 commit into from
Nov 28, 2020

Conversation

colemanw
Copy link
Member

Overview

A little code cleanup as a precursor to fixing https://lab.civicrm.org/dev/core/-/issues/2215

Before

  1. Variable CRM.tabSettings.active was overwritten when initializing tabs
  2. Campaign dashboard page initialized tabs again on every tab load.

After

  1. Avoid overwriting CRM.tabSettings.active by cloning the variable rather than copying by reference
  2. Initialize tabs only once on the Campaign dashboard

1. Avoid overwriting CRM.tabSettings.active by cloning the variable rather than copying by reference
2. Initialize tabs only once on the Campaign dashboard
@civibot
Copy link

civibot bot commented Nov 28, 2020

(Standard links)

@civibot civibot bot added the master label Nov 28, 2020
@colemanw colemanw changed the title Minor tabs cleanup toward fixing Minor tabs cleanup toward fixing dev/core#2215 Nov 28, 2020
@mattwire
Copy link
Contributor

Tested contact summary, configure event, message templates. All working as before.

@mattwire mattwire merged commit 5d21967 into civicrm:master Nov 28, 2020
@colemanw colemanw deleted the campaignTabs branch November 28, 2020 18:32
@colemanw
Copy link
Member Author

Thanks @mattwire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants