Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wordpress#63 Add action parameter to PCP shortcode #19058

Merged
merged 1 commit into from
Nov 26, 2020

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Nov 26, 2020

Overview

Add action parameter to PCP shortcode per https://lab.civicrm.org/dev/wordpress/-/issues/63

The parameters chosen are "info" and "transact" because I think this makes more sense than using "register" as used by event.

See civicrm/civicrm-wordpress#226 for the UI part of this

Before

No action parameter for PCP shortcodes.

After

Action parameter for PCP shortcodes.

Technical Details

Comments

@kcristiano @christianwach

@civibot
Copy link

civibot bot commented Nov 26, 2020

(Standard links)

@kcristiano
Copy link
Member

I've done r-run on this and civicrm/civicrm-wordpress#226

This works as it should and is ready to merge.

@kcristiano kcristiano added the merge ready PR will be merged after a few days if there are no objections label Nov 26, 2020
@eileenmcnaughton
Copy link
Contributor

@kcristiano are you hoping @christianwach will take a look pre merge? (this seems pretty uncontroversial so just wondering why you didn't merge)

@christianwach
Copy link
Member

@eileenmcnaughton It's Thanksgiving in the US.

Get's the thumbs up from me FWIW.

@christianwach
Copy link
Member

@eileenmcnaughton FYI I've merged civicrm/civicrm-wordpress#226

@seamuslee001
Copy link
Contributor

Merging as per feedback from Kevin and Christian

@seamuslee001 seamuslee001 merged commit 28682e6 into civicrm:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants