[REF] Cleanup Ang modules in core to follow conventions

[colemanw]

Overview

Each Angular module has a "definition" (typically in an .ang.php file) which consists of a small amount of information about where the html, js & css files are kept. Our goal is to cache Angular module definitions for performance, which means the data must be static. Historically .ang.php files were allowed to return an array of "settings" which could contain dynamic information (e.g. the current user's permission levels). That can't be cached, so instead modules can declare "settingsFactory" which is the name of a function which will return the settings.

Attention Extension Authors: You can refactor your own extensions simply by moving the settings array into a function.

• Example 1
• Example 2

Before

• crmAttachment module loaded settings at runtime.

After

• crmAttachment module loads settings via factory. Other references to settings removed.

Technical Details

This gets us another step closer to being able to autoload Angular modules in core and cache the list of modules.

Also renamed module statuspage to crmStatusPage to match file name crmStatusPage.ang.php.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Jenkins re test this please

[totten]

I haven't r-run, but r-code looks good. 👍

[seamuslee001]

@colemanw test seems to relate

Civi\Angular\ManagerTest::testGetModules
Expect to find at least one setting
Failed asserting that false is true.

[colemanw]

Thanks @seamuslee001 I fixed the test.

[eileenmcnaughton]

Since code changes involved the status screen & export I logged into the test site & checked those screens still loaded & responded to basic clicking - which they did. This seemed to be pending only r-run so I'm merging

[agileware-justin]

https://lab.civicrm.org/extensions/angularprofiles/-/issues/5 - org.civicrm.angularprofiles

And also relevant, https://lab.civicrm.org/extensions/angularprofiles/-/issues/3 - an we Deprecate This Extension?

[colemanw]

@agileware-justin [c]an we Deprecate This Extension?

Probably. But in the meantime I went ahead and fixed the notice: https://lab.civicrm.org/extensions/angularprofiles/-/merge_requests/2

[agileware-justin]

Thanks again @colemanw