Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra handling around contact id #19051

Merged
merged 1 commit into from
Nov 27, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

It's retrieved a few rows earlier from the contribution - this is from formerly
shared code that does not apply here

Same as #19050 but in paypal express handling code

Before

Extra code

After

poof

Technical Details

Comments

@civibot
Copy link

civibot bot commented Nov 25, 2020

(Standard links)

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001
Copy link
Contributor

@eileenmcnaughton this needs a rebase now but also I wonder about the test coverage here given the other related PR failed because of test coverage on Anet

It's retrieved a few rows earlier from the contribution - this is from formerly
shared code that does not apply here
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 testIPNPaymentExpressRecurSuccess would pick up if there was a problem - unlike the A.net one this is all in the same function

@seamuslee001
Copy link
Contributor

Looks fine to me merging

@seamuslee001 seamuslee001 merged commit 4a80483 into civicrm:master Nov 27, 2020
@seamuslee001 seamuslee001 deleted the pps branch November 27, 2020 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants