Check for membership type fee before applying tax

[alexymik]

Overview

Membership Types have an optional minimum fee which cause a PHP notice when no minimum is set and tax is applied.

Before

minimum_fee is used directly and can be unset.

After

Check for minimum_fee using array_key_exists() before using.

Technical Details

In CRM_Member_BAO_MembershipType::getAllMembershipTypes(), minimum_fee can be unset which causes a

Notice: Undefined index: minimum_fee

When trying to calculate minimum_fee_with_tax.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@alexymik thanks for this - I have a feeling it might be better to set minimum_fee_with_tax to 0 rather than leave unset since that would mean functions that don't use this out put don't need to handled it not being set.

Or maybe we should ensure minimum_fee is 0 if not set in the function this calls.

[alexymik]

I think the Membership Type API call should always return minimum_fee, with 0 for an unset minimum, but for now I've made the change you suggested.

[eileenmcnaughton]

@alexymik thanks - I'm happy to merge this if we can get the style issue sorted - it's just a trailing white space

[alexymik]

Sorry about that, web editor mishap.

[eileenmcnaughton]

@alexymik one last request - can you squah your commits into a single commit?

[eileenmcnaughton]

Thanks!