Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

afform/gui - Fix rendering of the "Form Settings" #18990

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

totten
Copy link
Member

@totten totten commented Nov 18, 2020

Overview

In the "Form Settings", some of the properties (such as "URL" and "Permissions") are not displayed.

Before

Screen Shot 2020-11-18 at 2 20 57 AM

After

Screen Shot 2020-11-18 at 2 20 26 AM

Technical Details

The <textarea/> tag is not interpreted as you might expect - it seems to be treated like <textarea> (without a closing). The subsequent text shows up in the DOM as subordinate content (but that initial DOM content is ultimately invisible because it's overriden by a data-binding ng-model="afform.description".).

The `<textarea/>` tag is misinterpreted, causing the subsequent fields to disappear.
@civibot
Copy link

civibot bot commented Nov 18, 2020

(Standard links)

@civibot civibot bot added the master label Nov 18, 2020
@colemanw colemanw merged commit 943cb2d into civicrm:master Nov 18, 2020
@totten totten deleted the master-afform-gui-url branch November 18, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants