Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove return value on transitionComponents #18979

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Nov 16, 2020

Overview

Follow up cleanup from #18964

We no longer use the result from transitionComponents so this removes most of the code that calculates the updateResult value.

Before

Value returned but never used

Screenshot from 2020-11-16 21-30-11

After

poof

Technical Details

There are still instances coming back from the cancel & fail functions that I will remove as a follow up

Comments

We no longer use the result from this function so this removes most of the code that calculates the updateResult value.

There are still instances coming back from the cancel & fail functions that I will remove as a follow up
@civibot
Copy link

civibot bot commented Nov 16, 2020

(Standard links)

@civibot civibot bot added the master label Nov 16, 2020
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 are you able to merge this? I kept it pretty small so it should be easy to see that it's not doing anything weird

@seamuslee001
Copy link
Contributor

Yeh this seems to make sense merging

@seamuslee001 seamuslee001 merged commit 74a98ec into civicrm:master Nov 17, 2020
@seamuslee001 seamuslee001 deleted the trans branch November 17, 2020 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants