Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't break clickthrough URLs when there's leading whitespace #18965

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

MegaphoneJon
Copy link
Contributor

Overview

Clickthrough tracking breaks when a URL has a leading space. See the Gitlab ticket for replication steps.

Before

Clickthrough tracking pukes when a leading space exists.

After

Clickthrough tracking works.

Technical Details

It's just a trim().

@civibot
Copy link

civibot bot commented Nov 12, 2020

(Standard links)

@civibot civibot bot added the master label Nov 12, 2020
@eileenmcnaughton
Copy link
Contributor

It IS just a trim

@eileenmcnaughton eileenmcnaughton merged commit f1d0837 into civicrm:master Nov 13, 2020
@totten
Copy link
Member

totten commented Nov 13, 2020

Apparently "Postel's Law" / "Robustness Principle" gets a shout-out in RFC 1122 (circa 1.2.2) which goes on to add:

In general, it is best to assume that the network is filled with malevolent entities

... such as spaces. :)

@MegaphoneJon MegaphoneJon deleted the mailing-80 branch December 17, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants