-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev/core#339 Install CiviCRM tables using utf8mb4 #18960
Conversation
(Standard links)
|
Cool. FYI these 4 tests should fail: #18828 (comment) The last one I think I was mistaken and it's also just a test update needed. |
Ok - so to articulate this makes it so that new installs install in utf8mb4 & the arguments are
|
d46fbe1
to
c6879fd
Compare
@eileenmcnaughton fixed the tests |
If you install sample data the custom field tables are still utf8 - from civicrm_generated.mysql. Otherwise looks good to me. |
c6879fd
to
cb4b8b2
Compare
Thanks @demeritcowboy updated that now @eileenmcnaughton you good to MOP this? |
d154f57
to
51e4235
Compare
Jenkins retest this please |
@seamuslee001 that was the 4th test that failed for me earlier. Me thinks it's a real fail and it doesn't like COMPRESSED. I was surprised it didn't fail the first time here. |
Update sample custom value tables as appropriate as well Fix conflict between test setting ROW_FORMAT being compressed and the ROW_FORMAT of the original table being DYNAMIC
51e4235
to
828c691
Compare
@demeritcowboy I think I have found it, I had updated install query to specify the ROW_FORMAT was to be DYNAMIC, the problem being is that that was being carried through to the log table even tho the test was specifying COMPRESSED which would have been ok other than the fact that the test was putting in a |
This was notified in the dev-digest. Tests now passing & we have discussed this - merging |
Overview
This changes the standard civicrm mysql tables to be in utf8mb4 and associated charset
Before
Tables installed using utf8
After
Tables installed using utf8mb4
ping @eileenmcnaughton @totten @demeritcowboy