Standardise more params in completeOrder

[eileenmcnaughton]

Overview

Standardise more params in completeOrder

Before

Handling to load the following from the previous contribution is specific to Authorize.net for

• amount_level
• address_id
• campaign_id

After

Handling moved to completeOrder. In the case of campaign_id it is only used if not set in input params or contribution recur record

Technical Details

I also removed $objects from

 $isFirstOrLastRecurringPayment = $this->recur($input, [
        'related_contact' => $ids['related_contact'] ?? NULL,
        'participant' => !empty($objects['participant']) ? $objects['participant']->id : NULL,
        'participant' => NULL,
        'contributionRecur' => $contributionRecur->id,
      ], $contributionRecur, $objects['contribution'], $first);
      ], $contributionRecur, $contribution, $first);

In the case of participant we actually don't do A.net IPNs for events as they are only processed on recurring for A.net and we don't have expectations for participants here - this is just copy & paste. In the case of $objects['contribution'], this was only set to $contribution a few lines earlier

$objects['contribution'] = &$contribution;

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@eileenmcnaughton this seems to be new in this PR? So we are saying that if the Recur object has a campaign we use that otherwise if there is a campaign in the template use that. I think that makes sense but might be worthwhile code documenting that this is a deliberate change

[eileenmcnaughton]

@seamuslee001 so the recur part is just moved - I guess it didn't have to be but it seemed clearer. The fall back to templateContribution was not done except for A.net before... unless they passed in campaign_id as an input param

[seamuslee001]

Agree that the recur part is just moved its just this template override part that felt new

[eileenmcnaughton]

OK - I've added a comment about falling back on the template value