dev/core#2165 Test for Handle emojis less fatally where not supported

[eileenmcnaughton]

Overview

Test for emoji find - demonstrates that using an emoji in the string currently results in a fatal error

Before

No test

After

test

Technical Details

What to do?

I'm honestly tempted just to swap the emoji for the word emoji when it is in the string - that would mean it's not found - which seems correct to me

We can use a construct something like

    $collation = CRM_Core_BAO_SchemaHandler::getInUseCollation();

    if (stripos($collation, 'utf8mb4') === FALSE) {
      // kill the owl
    }

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

@eileenmcnaughton check your style

[eileenmcnaughton]

@totten @seamuslee001 @colemanw this implements the approach we discussed - ie saying that by definition if your search criteria requires an emjoi and your database does not support emoji then the criteria resolves to false. When digging into the code this was the cleanest place to put it & given we currently get a hard fail putting it someone comprehensive seems good.

I've tried to limit calls to && max(array_map('ord', str_split($criterion))) >= 240) { as much as possible by doing cheaper checks first - but I note that not that in fact this function is not quite as high traffic as it seems as usually not that many criteria are set, even if many queries are run

[seamuslee001]

The idea seems to make sense to me but test fail seems related

[eileenmcnaughton]

@seamuslee001 passing now

[seamuslee001]

So this in essence passes but doesn't return any results which seems most sensible IMO

merging