Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv4 - Fix nonstandard camelCase of title_plural field #18873

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

colemanw
Copy link
Member

Overview

In a feature recently added by @agh1 and myself, the api returns the name of each entity in plural form as titlePlural. However, api output by convention does not use camelCase. This fixes it, adds the field to the api spec, and backports the test from master with the updated case.

Before

Api returns title and titlePlural for each entity.

After

Api returns title and title_plural for each entity.

Comments

There may be a conflict in forward-merging this to master. I'll fix that when we merge this.

@civibot
Copy link

civibot bot commented Oct 29, 2020

(Standard links)

@civibot civibot bot added the 5.31 label Oct 29, 2020
@eileenmcnaughton eileenmcnaughton merged commit efefb1d into civicrm:5.31 Oct 29, 2020
@eileenmcnaughton eileenmcnaughton deleted the title_plural branch October 29, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants