[Ref] Move sending the email back out of the recur function

[eileenmcnaughton]

Overview

[Ref] Move sending the email back out of the recur function

Before

The call to CRM_Contribute_BAO_ContributionPage::recurringNotify is within the recur function - it is only called from one place and variables are being wrangled / made confusing to pass through

After

The call to CRM_Contribute_BAO_ContributionPage::recurringNotify is back in 'Main' - we can start to stop passing in the $ids array (which we hope to fully deprecate as they can be calculated as easily in CompleteOrder)

Technical Details

This allows us not to pass in extra ids that are only required for that use and
steps us closer to not loading them

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@eileenmcnaughton looking at the 2 returns in the old lines 200 and 207 this might trigger this code when it wasn't previously being triggered

[eileenmcnaughton]

@seamuslee001 good call - I've switched them to FALSE

[seamuslee001]

this looks fine now