dev/membership#30 switch Membership import to use the v3 api #18821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ITturns out the addition of a unique name at some point caused is_override not to be passed in inn a way the BAO recognises - the api has handling for this...
|
(Standard links)
|
| @@ -308,9 +308,6 @@ public function import($onDuplicate, &$values) { | |||
| $params[$key] = $this->parsePseudoConstantField($val, $this->fieldMetadata[$key]); | |||
| break; | |||
|
|
|||
| case 'member_is_override': | |||
| $params[$key] = CRM_Utils_String::strtobool($val); | |||
There was a problem hiding this comment.
api handles this validation
| 'userId' => $session->get('userID'), | ||
| ]; | ||
| $newMembership = CRM_Member_BAO_Membership::create($formatted, $ids, TRUE); | ||
| if (civicrm_error($newMembership)) { |
There was a problem hiding this comment.
exceptions are caught further down in the function as the api is used elsewhere in this class
| // @todo stop passing $ids array (and put details in $formatted if required) | ||
| $ids = [ | ||
| 'membership' => $formatValues['membership_id'], | ||
| 'userId' => $session->get('userID'), |
There was a problem hiding this comment.
userId goes to modified it - which will default to this anyway
|
Merging as per review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix for https://lab.civicrm.org/dev/membership/-/issues/30 whereby is_override is ignored on import
Before
Steps in the gitlab but TLDR = 'is_override' column does not reach the BAO as 'is_override' but as 'member_is_override' - whic the BAO ignores
After
Api handles unique names by passing both the the BAO - we could strip out a lot of the function now....
Technical Details
It turns out the addition of a unique name at some point caused is_override not to be passed in
inn a way the BAO recognises - the api has handling for this...
Comments
Tests in
CRM_Member_Import_Parser_MembershipTestlook like they should have detected this but didn't