Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This code is repeated all over the task sub system. This is a first attempt to
extract it on the parent class in order to start consolidating it
Before
Code in main function & copied to many many places
After
Minor extraction to prepare for more cleanup
Technical Details
@monishdeb this is a follow on to the PR you merged - just about every task class seems to have a copy of this code & I think a lot of the nasty code on the task classes relates to it
Comments