Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract setNextUrl #18750

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Extract setNextUrl #18750

merged 1 commit into from
Oct 13, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

This code is repeated all over the task sub system. This is a first attempt to
extract it on the parent class in order to start consolidating it

Before

Code in main function & copied to many many places

After

Minor extraction to prepare for more cleanup

Technical Details

@monishdeb this is a follow on to the PR you merged - just about every task class seems to have a copy of this code & I think a lot of the nasty code on the task classes relates to it

Comments

This code is repeated all over the task sub system. This is a first attempt to
extract it on the parent class in order to start consolidating it
@civibot
Copy link

civibot bot commented Oct 13, 2020

(Standard links)

@civibot civibot bot added the master label Oct 13, 2020
@eileenmcnaughton eileenmcnaughton merged commit 974f977 into civicrm:master Oct 13, 2020
@eileenmcnaughton eileenmcnaughton deleted the weird branch October 13, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants