Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backdrop#116 Override sessionStart function and use backdrop function… #18745

Merged
merged 1 commit into from
Oct 24, 2020
Merged

backdrop#116 Override sessionStart function and use backdrop function… #18745

merged 1 commit into from
Oct 24, 2020

Conversation

seamuslee001
Copy link
Contributor

…s as appropriate

Overview

As per https://github.com/civicrm/civicrm-backdrop/issues/110 This overrides the backdrop Session start function in DrupalBase.php to use the backdrop specific functions

Before

DrupalBase function used and drupal functions used in backdrop

After

Backdrop system class used and backdrop functions used

ping @herbdool @totten

@civibot
Copy link

civibot bot commented Oct 12, 2020

(Standard links)

@civibot civibot bot added the master label Oct 12, 2020
@eileenmcnaughton
Copy link
Contributor

@herbdool is this on your radar?

@herbdool
Copy link
Contributor

This looks like a simple fix. Looks good to me

@eileenmcnaughton eileenmcnaughton merged commit 687c869 into civicrm:master Oct 24, 2020
@eileenmcnaughton
Copy link
Contributor

thanks @herbdool

@eileenmcnaughton eileenmcnaughton deleted the backdrop_session branch October 24, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seamuslee001 @eileenmcnaughton @herbdool