dev/financial#152 simplify interaction with membership, deprecate function

[eileenmcnaughton]

Overview

Minor code simplification in tested code

Before

$ids['membership'] is only used in one specific place in the IPN but it is determined early on & passed around

After

$ids['membership'] only determined where it is used.

Switch to calling sendRecurringStartOrEndNotification directly as the wrapper function only interprets $ids['membership'] into a bool for $autoRenewMembership and duplicates the IF

Technical Details

ids['membership'] is only calculated in the Authorize.net IPN flow for the purpose of determining
the autoRenew membership parameter for recurringNotify. This is currently passed to sendRecurringStartOrEndNotification
but that does not add any simplification & cannot be used elsewhere - so deprecating.

Comments

This is tested in testIPNPaymentMembershipRecurSuccessNoLeakage

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).