dev/financial#152 Remove unreachable code #18734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code cann only be reached if txnType is recurring_payment. Given that we can look at the earlier switch and see that in that case first must be TRUE or it would have already returned. Ergo this code is unreachable - and would have been since the earlier code switched to using the api to handle non-firsts
|
(Standard links)
|
|
Agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove unreachable code
Before
Code chunk exists that is only reachable when
$txnTypeis'recurring_payment'AND$firstis truthyBUT there is an early return a little earlier in the function if those conditions are true
Ergo this code is unreachable - and would have been
since the earlier code switched to using the api to handle non-firsts
After
poof
Technical Details
There is test cover on this function in
CRM_Core_Payment_PayPalProIPNTestbut it can't actually test code that can't be reachedComments