dev/financial#152 Remove unused parameters from BaseIPN->cancelled signature #18730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| @@ -264,7 +262,6 @@ public function cancelled(&$objects, $transaction = NULL, $input = []) { | |||
| ]); | |||
| $contribution->contribution_status_id = $contributionStatuses['Cancelled']; | |||
| $contribution->cancel_date = self::$_now; | |||
| $contribution->cancel_reason = $input['reasonCode'] ?? NULL; | |||
There was a problem hiding this comment.
since input is never passed in this would always be NULL
eileenmcnaughton
changed the title
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Oct 10, 2020
…ture Same as civicrm#18730 but for failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes some unused parameters, removes pass-by reference
Before
Cancelled called from 2 places - they only pass in $objects & never use it again
After
Technical Details
Comments