dev/financial#152 Pass contribution directly to completeOrder

[eileenmcnaughton]

Overview

Simplify function signature on internal completeOrder function

This addresses item 2 on https://lab.civicrm.org/dev/financial/-/issues/152

Before

 public static function completeOrder($input, $ids, $contribution, $isPostPaymentCreate = FALSE) {
    $contribution = $objects['contribution'];
    // Unset objects just to make it clear it's not used again.
    unset($objects);

After

public static function completeOrder($input, $ids, $contribution, $isPostPaymentCreate = FALSE) {

Technical Details

We have done quite a a bit of cleanup on this and the only value in objects now used is
contribution - this is really explicit in the code as we actually unset objects after
extracting contribution.

This alters the function signature such that it receives contribution directly rather than
in an array

Comments

These are the only places it is accessed from

All have test cover

@mattwire

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@seamuslee001 do you want to MOP this too - it's straight forward & will permit further cleanup

[mattwire]

Yes, we already discussed - merging.