Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2073 Fix use of legacy leaky method in tested code #18702

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 7, 2020

Overview

Fix use of legacy leaky method in tested code

Before

$dao = new CRM_Core_DAO();
            $dao->query($sql);

After

$dao = CRM_Core_DAO::executeQuery($sql);

Technical Details

Has test cover in
CRM_Member_Form_MembershipTest.testSubmitUpdateMembershipFromPartiallyPaid
CRM_Member_Form_MembershipTest.testMembershipViewContributionOwnerDifferent
api_v3_ContributionTest.testPendingToCompleteContribution

Comments

Overview
----------------------------------------
Fix use of legacy leaky method in tested code

Before
----------------------------------------

After
----------------------------------------

Technical Details
----------------------------------------
Has test cover in
CRM_Member_Form_MembershipTest.testSubmitUpdateMembershipFromPartiallyPaid
CRM_Member_Form_MembershipTest.testMembershipViewContributionOwnerDifferent

Comments
----------------------------------------
@civibot
Copy link

civibot bot commented Oct 7, 2020

(Standard links)

@civibot civibot bot added the master label Oct 7, 2020
@eileenmcnaughton
Copy link
Contributor Author

test this please

@seamuslee001 seamuslee001 merged commit d3b44cc into civicrm:master Oct 8, 2020
@seamuslee001 seamuslee001 deleted the leak8 branch October 8, 2020 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants