Greenwich - fix conflict btw bootstrap & jQuery UI button #18696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This calls noConflict on the Bootstrap3 $.fn.button() method, essentially getting rid of it, as it is not used by CiviCRM, whereas the jQuery UI $.fn.button() is used. If we needed the boostrap button function, we could rename it with something like: `$.fn.btn = $.fn.button.noConflict();`
|
(Standard links)
|
|
unrelated fail |
|
OK - we should get this in 5.31 to go with greenwich |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a problem in the new Greenwich Bootstrap3 theme causing buttons to disappear.
Before
After
Technical Details
This calls noConflict on the Bootstrap3$.fn.button() method, essentially getting rid of it, as it is not used by CiviCRM, whereas the jQuery UI $ .fn.button() is used.
If we needed the boostrap button function, we could rename it with something like:
$.fn.btn = $.fn.button.noConflict();Comments
This file was copied over from Shoreditch, which employs the same fix.