Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer.json - Update compile-lib and compile-plugin #18670

Merged
merged 2 commits into from
Oct 4, 2020

Conversation

totten
Copy link
Member

@totten totten commented Oct 4, 2020

Overview

This updates the version of composer-compile-lib and composer-compile-plugin. It addresses a few issues:

  • When installing on systems with E_ALL error-reporting, the file CCL.php was corrupted -- with PHP warnings misdirected into CCL.php. The update to composer-compile-lib fixes the underlying warning and directs future warnings to a better place (console output).
  • When installing on Drupal 8.7.11, the CI fails because 8.7.11 has a quirky dependency-graph. (The drupal/drupal package indirectly depends on itself.) The update to composer-compile-plugin handles this quirk properly.

Before and After

  - Updating civicrm/composer-compile-plugin (v0.10 => v0.12)
  - Updating civicrm/composer-compile-lib (v0.2 => v0.3)

Technical Details

Strictly speaking, new installs and upgrades on D8/D9 should start using the updated packages without this PR. This just makes it a little clearer and brings D7/WP/BD along.

CC @seamuslee001 @eileenmcnaughton

@civibot civibot bot added the master label Oct 4, 2020
@civibot
Copy link

civibot bot commented Oct 4, 2020

(Standard links)

@seamuslee001 seamuslee001 merged commit f8a2dd3 into civicrm:master Oct 4, 2020
@totten totten deleted the master-compup branch October 4, 2020 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants