dev/core#2079 [REF] clean up call to apiQuery #18664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Oct 2, 2020
This fixes
1) fixes apiQuery to be called statically as it is a static function
2) casts results directly to detail
This is the copy & paste source of civicrm#18664 I guess....
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Oct 3, 2020
This fixes
1) fixes apiQuery to be called statically as it is a static function
2) casts results directly to detail
This is the copy & paste source of civicrm#18664 I guess....
|
@eileenmcnaughton I tried finding a unit test that covered this but couldn't |
|
@seamuslee001 you are right - that class had no cover (& is only called from Member_label despite it's name). I've added a basic 'no error' test to at least ensure this code is passed through. |
This fixes a few things 1) fixes apiQuery to be called statically as it is a static function 2) casts results directly to detail 3) removes unnused variable
|
ug - some sort of caching in jenkins - added a couple of lines to try to find it. |
|
@seamuslee001 ok - the test is passing now |
|
changes seem fine now merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes a few things
Before
After
Technical Details
The query object that is instantiated is not used in the static function, which instantiates it's own
Comments