dev/core#2079 [Ref] Clarify calls to CRM_Utils_Token::getTokenDetails

[eileenmcnaughton]

Overview

This changes the call to getTokenDetails to make it clearer that only the first parameter is used.

The second parameter is an unused query that we should eliminate but getting it
easier to scan is a good first step

Before

$tokenResolvedContacts = CRM_Utils_Token::getTokenDetails(['contact_id' => $contactID],

then used as $tokenResolvedContacts[0]

After

[$tokenResolvedContacts] = CRM_Utils_Token::getTokenDetails(['contact_id' => $contactID],

then used without the [0]

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

@eileenmcnaughton Can you please update the comment for the return value on getTokenDetails() dockblock as well? Once I worked out why this PR makes sense and is correct but I'd have got there quicker if the docblock explained what params are in that return array.

[eileenmcnaughton]

@mattwire I never really worked it out :-) My goal is to confirm the second value not used anywhere & then just remove it

[eileenmcnaughton]

@mattwire the PR to remove it altogether is here #18657