Fix cache bypass

[eileenmcnaughton]

Overview

Minor performance fix - If the contact is not impacted by any acls then ids will be an empty array. However, currently
an empty array is treated as 'uncached' rather than 'cached by empty' which
would be represented by null

Before

If the contact does not have any applicable acls the cached empty array is ignored and the acls are computed each time

After

Code only does the queries if the cache returns NULL, not an empty array

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Test fails look related @eileenmcnaughton

api_v3_UFFieldTest.testACLPermissionforProfiles
CRM_Group_Page_AjaxTest.testTraditionalACL
CRM_Group_Page_AjaxTest.testTraditionalACLFoundTitle
CRM_Group_Page_AjaxTest.testTraditionalACLDisabled
CRM_Group_Page_AjaxTest.testTraditionalACLDisabledFoundTitle
CRM_Group_Page_AjaxTest.testTraditionalACLEnabled
CRM_Group_Page_AjaxTest.testTraditionalACLAll

[eileenmcnaughton]

yeah interesting - will look

[eileenmcnaughton]

@seamuslee001 it looks like it was a hidden bug in the cachekey

[seamuslee001]

This looks fine merging