Skip to content

dev/core#2075 - E_NOTICE viewing an activity that has no details contents #18637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

demeritcowboy
Copy link
Contributor

Overview

https://lab.civicrm.org/dev/core/-/issues/2075

  1. Create an activity, e.g. a Meeting.
  2. Don't put anything in the details field.
  3. Save.
  4. Turn off popups at admin - customize - display prefs, or in the next step use right-click and view in new tab/window.
  5. View the activity.

Before

Notice: Undefined index: details in CRM_Activity_Form_Activity->preProcess() (line 506 of .../CRM/Activity/Form/Activity.php)

After

@civibot
Copy link

civibot bot commented Sep 29, 2020

(Standard links)

@civibot civibot bot added the master label Sep 29, 2020
@seamuslee001
Copy link
Contributor

Looks fine to me MOP

@eileenmcnaughton eileenmcnaughton merged commit 853a0e3 into civicrm:master Sep 30, 2020
@demeritcowboy
Copy link
Contributor Author

Thanks!

@demeritcowboy demeritcowboy deleted the no-details branch September 30, 2020 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants